Re: [PATCH v2 03/10] blktrace: fix debugfs use after free

[Luis Chamberlain]

On Sun, Apr 19, 2020 at 05:38:59PM -0700, Bart Van Assche wrote:
> On 4/19/20 5:04 PM, Luis Chamberlain wrote:
> > > Independent of what the purpose of the above code is, can that code be
> > > rewritten such that it does not depend on the details of how names are
> > > assigned to disks and partitions? Would disk_get_part() be useful here?
> > 
> > I did try, but couldn't figure out a way. I'll keep looking but likewise
> > let me know if you find a way.
> 
> How about making blk_trace_setup() pass the result of the following
> expression as an additional argument to blk_trace_setup():
> 
> 	bdev != bdev->bd_contains
> 
> I think that is a widely used approach to verify after a block device has
> been opened whether or not 'bdev' refers to a partition (bdev !=
> bdev->bd_contains means that 'bdev' represents a partition).

Sweet, that should simplify this considerbly, thanks!

  Luis