Re: [PATCH] scsi: mpt3sas: use true,false for bool variables

[Suganath Prabu Subramani]

Acked-by: Suganath Prabu <suganath-prabu.subramani@xxxxxxxxxxxx>

Thanks.



On Tue, Apr 21, 2020 at 9:12 AM Jason Yan <yanaijie@xxxxxxxxxx> wrote:
>
> Fix the following coccicheck warning:
>
> drivers/scsi/mpt3sas/mpt3sas_base.c:416:6-14: WARNING: Assignment of 0/1
> to bool variable
> drivers/scsi/mpt3sas/mpt3sas_base.c:485:2-10: WARNING: Assignment of 0/1
> to bool variable
>
> Signed-off-by: Jason Yan <yanaijie@xxxxxxxxxx>
> ---
>  drivers/scsi/mpt3sas/mpt3sas_base.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c
> index 06285b03fa00..4544ba4bf47d 100644
> --- a/drivers/scsi/mpt3sas/mpt3sas_base.c
> +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c
> @@ -413,7 +413,7 @@ static void _clone_sg_entries(struct MPT3SAS_ADAPTER *ioc,
>  {
>         Mpi2SGESimple32_t *sgel, *sgel_next;
>         u32  sgl_flags, sge_chain_count = 0;
> -       bool is_write = 0;
> +       bool is_write = false;
>         u16 i = 0;
>         void __iomem *buffer_iomem;
>         phys_addr_t buffer_iomem_phys;
> @@ -482,7 +482,7 @@ static void _clone_sg_entries(struct MPT3SAS_ADAPTER *ioc,
>
>         if (le32_to_cpu(sgel->FlagsLength) &
>                         (MPI2_SGE_FLAGS_HOST_TO_IOC << MPI2_SGE_FLAGS_SHIFT))
> -               is_write = 1;
> +               is_write = true;
>
>         for (i = 0; i < MPT_MIN_PHYS_SEGMENTS + ioc->facts.MaxChainDepth; i++) {
>
> --
> 2.21.1
>