RE: [RFC] WRITE_ONCE_INC() and friends
From: David Laight
Date: Tue Apr 21 2020 - 04:00:54 EST
From: Petko Manolov
> Sent: 20 April 2020 17:32
...
> > But one downside of declaring variables volatile is that it can prevent KCSAN
> > from spotting violations of the concurrency design for those variables.
>
> Which would be unfortunate.
>
> I just wish there was C type declaration that would force the compiler to do
> what READ/WRITE_ONCE() does now, but i also know this is too naive... :)
It does, it is called 'volatile'.
All READ_ONCE() does is force the access through a volatile pointer.
The thing to do is mark the structure elements 'volatile'
rather than using a 'pointer to volatile structure'.
I'm sure KASAN could be taught about volatile structure members.
David.
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)