Re: [PATCH 04/18] mm: memcontrol: move out cgroup swaprate throttling

From: Alex Shi
Date: Tue Apr 21 2020 - 05:12:47 EST




在 2020/4/21 上午6:11, Johannes Weiner 写道:
> The cgroup swaprate throttling is about matching new anon allocations
> to the rate of available IO when that is being throttled. It's the io
> controller hooking into the VM, rather than a memory controller thing.
>
> Rename mem_cgroup_throttle_swaprate() to cgroup_throttle_swaprate(),
> and drop the @memcg argument which is only used to check whether the
> preceding page charge has succeeded and the fault is proceeding.
>
> We could decouple the call from mem_cgroup_try_charge() here as well,
> but that would cause unnecessary churn: the following patches convert
> all callsites to a new charge API and we'll decouple as we go along.
>
> Signed-off-by: Johannes Weiner <hannes@xxxxxxxxxxx>

Reviewed-by: Alex Shi <alex.shi@xxxxxxxxxxxxxxxxx>