Re: [RFC PATCH v11 1/9] psci: export psci conduit get helper.
From: Mark Rutland
Date: Tue Apr 21 2020 - 05:41:14 EST
On Tue, Apr 21, 2020 at 11:22:56AM +0800, Jianyong Wu wrote:
> Export arm_smccc_1_1_get_conduit then modules can use smccc helper which
> adopts it.
>
> Signed-off-by: Jianyong Wu <jianyong.wu@xxxxxxx>
Nit: please say 'smccc conduit' in the commit title.
Otherwise, I see not problem with this provided an in-tree module uses
this, so:
Acked-by: Mark Rutland <mark.rutland@xxxxxxx>
Mark.
> ---
> drivers/firmware/psci/psci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/firmware/psci/psci.c b/drivers/firmware/psci/psci.c
> index 2937d44b5df4..fd3c88f21b6a 100644
> --- a/drivers/firmware/psci/psci.c
> +++ b/drivers/firmware/psci/psci.c
> @@ -64,6 +64,7 @@ enum arm_smccc_conduit arm_smccc_1_1_get_conduit(void)
>
> return psci_ops.conduit;
> }
> +EXPORT_SYMBOL(arm_smccc_1_1_get_conduit);
>
> typedef unsigned long (psci_fn)(unsigned long, unsigned long,
> unsigned long, unsigned long);
> --
> 2.17.1
>