Re: [PATCH] remove the no longer needed pid_alive() check in __task_pid_nr_ns()

From: Christian Brauner
Date: Tue Apr 21 2020 - 06:50:54 EST


On Tue, Apr 21, 2020 at 12:19:04PM +0200, Oleg Nesterov wrote:
> Starting from 2c4704756cab ("pids: Move the pgrp and session pid pointers
> from task_struct to signal_struct") __task_pid_nr_ns() doesn't dereference
> task->group_leader, we can remove the pid_alive() check.
>
> pid_nr_ns() has to check pid != NULL anyway, pid_alive() just adds the
> unnecessary confusion.
>
> Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>
> ---

Acked-by: Christian Brauner <christian.brauner@xxxxxxxxxx>