Re: [PATCH 3/3] perf stat: Add --metrics-file option

[Jiri Olsa]

On Tue, Apr 21, 2020 at 11:36:15AM -0700, Andi Kleen wrote:
> > +--metrics-file file::
> > +Read metrics definitions from file in addition to compiled in metrics.
> > +
> 
> You would need to define the syntax and format. Perhaps in a separate
> man page.

I'm not sure it's worthy of new man page, but perhaps section in
perf-stat

> 
> Also there are some asserts that can be triggered by expressions. I think
> you should fix those too and convert them to errors.

do you have some details on this? examples of those failures?

thanks,
jirka

> 
> -Andi
>