Re: [PATCH v2] tpm/tpm_tis: Free IRQ if probing fails

[Hans de Goede]

Hi,

On 4/21/20 9:54 PM, Jarkko Sakkinen wrote:
> On Tue, Apr 21, 2020 at 03:23:19PM +0200, Hans de Goede wrote:
> > Hi,
> >
> > On 4/16/20 6:07 PM, Jarkko Sakkinen wrote:
> > > Call disable_interrupts() if we have to revert to polling in order not to
> > > unnecessarily reserve the IRQ for the life-cycle of the driver.
> > >
> > > Cc: stable@xxxxxxxxxxxxxxx # 4.5.x
> > > Reported-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> > > Fixes: e3837e74a06d ("tpm_tis: Refactor the interrupt setup")
> > > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx>
> >
> > I can confirm that this fixes the "irq 31 nobody cared" oops for me:
> >
> > Tested-by: Hans de Goede <hdegoede@xxxxxxxxxx>
>
> Hi, thanks a lot! Unfortunately I already put this out given the
> criticality of the issue:
>
> https://lkml.org/lkml/2020/4/20/1544
>
> Sincere apologies that I couldn't include your tested-by

No problem.

> but the most
> important thing is to know that it works now.

Agreed.

Regards,

Hans