Re: [PATCH v2 0/2] objtool: add support for >64k sections
From: Josh Poimboeuf
Date: Tue Apr 21 2020 - 19:52:41 EST
On Tue, Apr 21, 2020 at 03:08:41PM -0700, Sami Tolvanen wrote:
> This series fixes objtool for binaries with >64k sections, and
> includes optimizations to reduce the runtime for a binary with
> ~130k sections from >15 minutes to ~4 seconds.
>
> Changes in v2:
> - Dropped the insn_hash optimization as Peter has a nearly
> similar change queued already.
> - Instead of storing the last instruction for each section,
> use find_insn to locate it.
>
>
> Sami Tolvanen (2):
> objtool: use gelf_getsymshndx to handle >64k sections
> objtool: optimize add_dead_ends for split sections
>
> tools/objtool/check.c | 36 +++++++++++++++++-------------------
> tools/objtool/elf.c | 24 +++++++++++++++++-------
> 2 files changed, 34 insertions(+), 26 deletions(-)
>
>
> base-commit: 18bf34080c4c3beb6699181986cc97dd712498fe
Looks good to me, thanks. I'll add them to the queue for testing, along
with that other patch.
--
Josh