Re: [PATCH 01/10] mm/page-flags: introduce PageHighMemZone()

From: Roman Gushchin
Date: Tue Apr 21 2020 - 21:03:31 EST


On Tue, Apr 21, 2020 at 02:00:05AM -0700, Christoph Hellwig wrote:
> I don't think the names are very good. I'd keep PageHighMem for the
> existing highmem zone, and add something like PageDirectMapped or
> similar for ay page that has a valid direct mapping address. This will
> also come in handy if we plan to go ahead with the xpfo work.
>

I agree. It also looks like the only remaining place with PageHighMem()
is using "if (!PageHighMem(page))", so "if (PageDirectlyMapped(page))" would be
even better.

Joonsoo, the series in general looks very good to me. Please, feel free
to add "Acked-by: Roman Gushchin <guro@xxxxxx>".

Thanks!