Re: [PATCH 1/9] vboxsf: don't use the source name in the bdi name

[Hans de Goede]

Hi,

On 4/22/20 9:38 AM, Christoph Hellwig wrote:
> Simplify the bdi name to mirror what we are doing elsewhere, and
> drop them name in favor of just using a number.  This avoids a
> potentially very long bdi name.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good to me:

Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>

Regards,

Hans


> ---
>   fs/vboxsf/super.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/vboxsf/super.c b/fs/vboxsf/super.c
> index 675e26989376..8fe03b4a0d2b 100644
> --- a/fs/vboxsf/super.c
> +++ b/fs/vboxsf/super.c
> @@ -164,7 +164,7 @@ static int vboxsf_fill_super(struct super_block *sb, struct fs_context *fc)
>   		goto fail_free;
>   	}
>   
> -	err = super_setup_bdi_name(sb, "vboxsf-%s.%d", fc->source, sbi->bdi_id);
> +	err = super_setup_bdi_name(sb, "vboxsf-%d", sbi->bdi_id);
>   	if (err)
>   		goto fail_free;
>