Re: [PATCH -next] crypto: hisilicon/qm - Make qm_controller_reset() static

From: Zhou Wang
Date: Wed Apr 22 2020 - 22:31:35 EST


On 2020/4/23 10:22, Zou Wei wrote:
> Fix the following sparse warning:
>
> drivers/crypto/hisilicon/qm.c:3079:5: warning: symbol 'qm_controller_reset'
> was not declared. Should it be static?

It should be static.

>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Zou Wei <zou_wei@xxxxxxxxxx>

Reviewed-by: Zhou Wang <wangzhou1@xxxxxxxxxxxxx>

Thanks,
Zhou

> ---
> drivers/crypto/hisilicon/qm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c
> index 80c5525..69d02cb 100644
> --- a/drivers/crypto/hisilicon/qm.c
> +++ b/drivers/crypto/hisilicon/qm.c
> @@ -3076,7 +3076,7 @@ static int qm_controller_reset_done(struct hisi_qm *qm)
> return 0;
> }
>
> -int qm_controller_reset(struct hisi_qm *qm)
> +static int qm_controller_reset(struct hisi_qm *qm)
> {
> struct pci_dev *pdev = qm->pdev;
> int ret;
>