Re: [PATCH 2/2] rtw88: Use udelay instead of usleep in atomic context

From: Kai-Heng Feng
Date: Thu Apr 23 2020 - 02:53:27 EST




> On Apr 23, 2020, at 14:49, Kalle Valo <kvalo@xxxxxxxxxxxxxx> wrote:
>
> Kai-Heng Feng <kai.heng.feng@xxxxxxxxxxxxx> writes:
>
>> It's incorrect to use usleep in atomic context.
>>
>> Switch to a macro which uses udelay instead of usleep to prevent the issue.
>>
>> Signed-off-by: Kai-Heng Feng <kai.heng.feng@xxxxxxxxxxxxx>
>
> This fixes a regression, right? So there should be a Fixes line.

Yes, but the regression commit isn't in Linus' tree, so the sha1 may change.

Kai-Heng

>
> Also I can't take this until patch 1 is in my tree. And I don't know who
> takes iopoll.h patches.
>
> --
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches