Re: [PATCH] arm64: dts: allwinner: a64: Disable SPDIF by default

[Maxime Ripard]

On Wed, Apr 22, 2020 at 06:50:54PM -0500, Samuel Holland wrote:
> Maxime,
> 
> On 4/22/20 10:16 AM, Maxime Ripard wrote:
> > On Tue, Apr 21, 2020 at 11:15:02PM -0500, Samuel Holland wrote:
> >> As of v5.7-rc2, Linux now prints the following message at boot:
> >>
> >>   [   33.848525] platform sound_spdif: deferred probe pending
> >>
> >> This is because &sound_spdif is waiting on its DAI link component
> >> &spdif to probe, but &spdif is disabled in the DTS. Disable the
> >> audio card as well to match.
> >>
> >> Signed-off-by: Samuel Holland <samuel@xxxxxxxxxxxx>
> > 
> > The patch looks good, but don't we have some boards with SPDIF enabled that
> > should be modified accordingly?
> 
> I don't see any in-tree. The only A64 DTS that references &spdif at all is
> sun50i-a64-pine64.dts, which explicitly disables it:
> 
> 	/* On Euler connector */
> 	&spdif {
>   		status = "disabled";
> 	};
> 
> I'm leaning toward agreeing with Clement that the sound_spdif node (and also
> spdif_out) should be removed altogether from the A64 DTSI.

Yeah, I agree, it's pretty much what we've been doing in other SoCs. Especially
if we don't have any DT in-tree using it, we don't really have any incentive to
make it common.

Maxime

Attachment: signature.asc
Description: PGP signature