Re: [PATCH][next] net: phy: bcm54140: fix less than zero comparison on an unsigned

[Michael Walle]

Am 2020-04-23 16:10, schrieb Colin King:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Currently the unsigned variable tmp is being checked for an negative
> error return from the call to bcm_phy_read_rdb and this can never
> be true since tmp is unsigned.  Fix this by making tmp a plain int.
>
> Addresses-Coverity: ("Unsigned compared against 0")
> Fixes: 4406d36dfdf1 ("net: phy: bcm54140: add hwmon support")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

FWIW since Andrew already reviewed it:

Reviewed-by: Michael Walle <michael@xxxxxxxx>

-michael