Re: [PATCH 3/6] iio: chemical: scd30: add serial interface driver

[Tomasz Duszynski]

On Wed, Apr 22, 2020 at 10:55:05PM +0300, Andy Shevchenko wrote:
> On Wed, Apr 22, 2020 at 5:22 PM Tomasz Duszynski
> <tomasz.duszynski@xxxxxxxxxxx> wrote:
> >
> > Add serial interface driver for the SCD30 sensor.
>
> ...
>
> > +#include <linux/of_irq.h>
>
> Do you need this?
>
> > +static int scd30_serdev_probe(struct serdev_device *serdev)
> > +{
> > +       struct device *dev = &serdev->dev;
> > +       struct scd30_serdev_priv *priv;
> > +       int irq, ret;
> > +
> > +       priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> > +       if (!priv)
> > +               return -ENOMEM;
>
> > +       irq = of_irq_get(dev->of_node, 0);
>
> fwnode_irq_get() ?

Okay, that should work equally good.

>
> > +       if (irq <= 0)
> > +               irq = 0;
> > +
> > +       return scd30_probe(dev, irq, KBUILD_MODNAME, priv,
> > +                          scd30_serdev_command);
> > +}
>
> --
> With Best Regards,
> Andy Shevchenko