Re: [linux-sunxi] [PATCH v2 1/2] media: cedrus: Program output format during each run

[Jernej Åkrabec]

Dne sreda, 22. april 2020 ob 06:04:09 CEST je Samuel Holland napisal(a):
> Previously, the output format was programmed as part of the ioctl()
> handler. However, this has two problems:
> 
>   1) If there are multiple active streams with different output
>      formats, the hardware will use whichever format was set last
>      for both streams. Similary, an ioctl() done in an inactive
>      context will wrongly affect other active contexts.
>   2) The registers are written while the device is not actively
>      streaming. To enable runtime PM tied to the streaming state,
>      all hardware access needs to be moved inside cedrus_device_run().
> 
> The call to cedrus_dst_format_set() is now placed just before the
> codec-specific callback that programs the hardware.
> 
> Fixes: 50e761516f2b ("media: platform: Add Cedrus VPU decoder driver")
> Suggested-by: Jernej Åkrabec <jernej.skrabec@xxxxxxxxx>
> Suggested-by: Paul Kocialkowski <paul.kocialkowski@xxxxxxxxxxx>
> Signed-off-by: Samuel Holland <samuel@xxxxxxxxxxxx>

For what is worth:
Tested-by: Jernej Skrabec <jernej.skrabec@xxxxxxxx>
Reviewed-by: Jernej Skrabec <jernej.skrabec@xxxxxxxx>

Best regards,
Jernej