Re: [PATCH V10 07/11] fs/xfs: Create function xfs_inode_should_enable_dax()

From: Dave Chinner
Date: Thu Apr 23 2020 - 18:36:24 EST


On Wed, Apr 22, 2020 at 02:20:58PM -0700, ira.weiny@xxxxxxxxx wrote:
> From: Ira Weiny <ira.weiny@xxxxxxxxx>
>
> xfs_inode_supports_dax() should reflect if the inode can support DAX not
> that it is enabled for DAX.
>
> Change the use of xfs_inode_supports_dax() to reflect only if the inode
> and underlying storage support dax.
>
> Add a new function xfs_inode_should_enable_dax() which reflects if the
> inode should be enabled for DAX.
>
> Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> Signed-off-by: Ira Weiny <ira.weiny@xxxxxxxxx>

Looks fine.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
--
Dave Chinner
david@xxxxxxxxxxxxx