Re: [PATCH net-next] net: systemport: suppress warnings on failed Rx SKB allocations

From: Florian Fainelli
Date: Thu Apr 23 2020 - 21:48:06 EST




On 4/23/2020 4:13 PM, Doug Berger wrote:
> The driver is designed to drop Rx packets and reclaim the buffers
> when an allocation fails, and the network interface needs to safely
> handle this packet loss. Therefore, an allocation failure of Rx
> SKBs is relatively benign.
>
> However, the output of the warning message occurs with a high
> scheduling priority that can cause excessive jitter/latency for
> other high priority processing.
>
> This commit suppresses the warning messages to prevent scheduling
> problems while retaining the failure count in the statistics of
> the network interface.
>
> Signed-off-by: Doug Berger <opendmb@xxxxxxxxx>

Acked-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
--
Florian