Re: [PATCH v2 00/11] perf metric fixes and test
From: Jin, Yao
Date: Thu Apr 23 2020 - 22:46:19 EST
On 4/23/2020 10:31 PM, Ian Rogers wrote:
On Thu, Apr 23, 2020 at 7:03 AM Jiri Olsa <jolsa@xxxxxxxxxx> wrote:
On Thu, Apr 23, 2020 at 09:44:24PM +0800, Jin, Yao wrote:
Hi Jiri,
On 4/23/2020 7:28 PM, Jiri Olsa wrote:
On Wed, Apr 22, 2020 at 03:04:19PM -0700, Ian Rogers wrote:
Add a test that all perf metrics (for your architecture) are
parsable. Fix bugs in the expr parser and in x86 metrics. Untested on
architectures other than x86.
v2 adds Fixes tags to commit messages for when broken metrics were
first added. Adds a debug warning for division by zero in expr, and
adds a workaround for id values in the expr test necessary for
powerpc. It also fixes broken power8 and power9 metrics.
looks good to me
Jin Yao, is there a metric that's not working for you with this patchset
applied?
thanks,
jirka
Let me look for a CLX for testing, but maybe need some time.
BTW, suppose this patchset can work well, does it mean we will change the
json file format in future?
For example,
before:
cha@event\\=0x36\\\\\\
after:
cha@event\\=0x36\\
"\\\\" are removed.
If so, we need to change our event generation script.
ok, maybe I got the wrong idea that the extra \\\\ were just
superfluous, what was the actual error there? and what's the
reason for that many '\' in there?
I believe they are superfluous and break even before the flex change.
I commented on it here with a reproduction of a parse events error on
skylake:
https://lore.kernel.org/lkml/CAP-5=fUnWAycQehCJ9=btquV2c3DVDX+tTEc85H8py9Kfehq4w@xxxxxxxxxxxxxx/
Fixing the script that generates this would be great! With the test
landed it should be much harder for this to be broken in the future.
Thanks,
Ian
Tested on CLX and the error disappeared.
BTW, I will post the latest version of event list once the testing is
completed.
Thanks
Jin Yao
jirka