Re: [PATCH net-next] ptp: clockmatrix: remove unnecessary comparison

[Sergei Shtylyov]

Hello!

On 24.04.2020 11:14, Yang Yingliang wrote:

> The type of loaddr is u8 which is always '<=' 0xff, so the
> loaddr <= 0xff is always true, we can remove this comparison.
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
> ---
>   drivers/ptp/ptp_clockmatrix.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ptp/ptp_clockmatrix.c b/drivers/ptp/ptp_clockmatrix.c
> index 032e112..56aee4f 100644
> --- a/drivers/ptp/ptp_clockmatrix.c
> +++ b/drivers/ptp/ptp_clockmatrix.c
> @@ -780,7 +780,7 @@ static int idtcm_load_firmware(struct idtcm *idtcm,
>   
>   			/* Page size 128, last 4 bytes of page skipped */
>   			if (((loaddr > 0x7b) && (loaddr <= 0x7f))
> -			     || ((loaddr > 0xfb) && (loaddr <= 0xff)))
> +			     || loaddr <= 0xff)

   Haven't you just said that this is always true? :-)

[...]

MBR, Sergei