Re: [PATCH v3] console: newport_con: fix an issue about leak related system resources
From: Markus Elfring
Date: Fri Apr 24 2020 - 12:55:02 EST
> The corresponding system resources were not released then.
How do you think about a wording variant like the following?
Subject:
[PATCH v4] console: newport_con: Fix incomplete releasing of system resources
Change description:
* A call of the function do_take_over_console() can fail here.
The corresponding system resources were not released then.
Thus add a call of iounmap() and release_mem_region()
together with the check of a failure predicate.
* Add also a call of release_mem_region() for the completion
of resource clean-up on device removal.
It can be nicer if all patch reviewers (including me) will be explicitly specified
as recipients for such messages, can't it?
Regards,
Markus