RE: [PATCH v2] IB/rdmavt: return proper error code
From: Marciniszyn, Mike
Date: Fri Apr 24 2020 - 12:59:42 EST
> Subject: [PATCH v2] IB/rdmavt: return proper error code
>
> The commit 'ff23dfa13457' modified rvt_create_mmap_info() to return
> error code and also NULL but missed fixing codes which called
> rvt_create_mmap_info(). Modify rvt_create_mmap_info() to only return
> errorcode and fix error checking after rvt_create_mmap_info() was
> called.
>
> Fixes: ff23dfa13457 ("IB: Pass only ib_udata in function prototypes")
> Cc: stable@xxxxxxxxxxxxxxx [5.4+]
> Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@xxxxxxxxx>
I just tested the exact same patch!
Just a nit, adjust the comments for rvt_create_mmap_info():
* Return: rvt_mmap struct on success, ERR_PTR on failure
Tested-by: Mike Marciniszyn <mike.marciniszyn@xxxxxxxxx>
Acked-by: Mike Marciniszyn <mike.marciniszyn@xxxxxxxxx>
Mike