Re: [PATCH 2/3] soc: qcom: rpmh-rsc: Loop over less bits in irq handler

[Stephen Boyd]

Quoting Doug Anderson (2020-04-24 10:13:43)
> Hi,
> 
> On Fri, Apr 24, 2020 at 10:11 AM Doug Anderson <dianders@xxxxxxxxxxxx> wrote:
> >
> > Hi,
> >
> > On Thu, Apr 23, 2020 at 9:54 PM Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote:
> > >
> > > readl returns a u32, and BITS_PER_LONG is different on 32-bit vs. 64-bit
> > > architectures. Let's make the type we stash the readl into a u32 and
> > > then loop over the bits set in that type instead of potentially looping
> > > over more bits than we will ever need to.
> > >
> > > Cc: Maulik Shah <mkshah@xxxxxxxxxxxxxx>
> > > Cc: Douglas Anderson <dianders@xxxxxxxxxxxx>
> > > Signed-off-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>
> > > ---
> > >  drivers/soc/qcom/rpmh-rsc.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
> 
> Oh, I suppose one nit is s/less/fewer/ in the subject.  "bits" are
> discrete / countable, not continuous / uncountable.
> 

Ok that's good.