Re: [PATCH 1/4] PCI: dra7xx: Don't select CONFIG_PCI_DRA7XX_HOST by default
From: Bjorn Helgaas
Date: Fri Apr 24 2020 - 15:30:11 EST
On Wed, Apr 22, 2020 at 02:29:57PM -0500, Rob Herring wrote:
> On Tue, Apr 14, 2020 at 07:12:41PM -0500, Bjorn Helgaas wrote:
> > From: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> >
> > Drivers should not be selected by default because that bloats the kernel
> > for people who don't need them.
> >
> > Remove the "default y" for CONFIG_PCI_DRA7XX_HOST.
> >
> > Signed-off-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> > Cc: Kishon Vijay Abraham I <kishon@xxxxxx>
> > Cc: linux-omap@xxxxxxxxxxxxxxx
> > ---
> > drivers/pci/controller/dwc/Kconfig | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
> > index 03dcaf65d159..ea335ee7ca8e 100644
> > --- a/drivers/pci/controller/dwc/Kconfig
> > +++ b/drivers/pci/controller/dwc/Kconfig
> > @@ -26,7 +26,6 @@ config PCI_DRA7XX_HOST
> > depends on OF && HAS_IOMEM && TI_PIPE3
> > select PCIE_DW_HOST
> > select PCI_DRA7XX
> > - default y
>
> Perhaps 'default y if SOC_DRA7XX'?
Good idea, I did that.