Re: [PATCH] net: macb: fix an issue about leak related to system resources

From: Markus Elfring
Date: Sat Apr 25 2020 - 13:00:56 EST


> A call of the function macb_init() can fail in the function
> fu540_c000_init. The related system resources were not released
> then. use devm_ioremap() to replace ioremap() for fix it.

How do you think about a wording variant like the following?

Subject:
[PATCH v2] net: macb: Use devm_ioremap() in fu540_c000_init()

Change description:
A call of the macb_init() function can fail here.
The corresponding system resources were not released then.
Thus replace a call of the ioremap() function by devm_ioremap().


Regards,
Markus