Re: [RFC PATCH v10 6/9] media: tegra: Add Tegra210 Video input driver

From: Dmitry Osipenko
Date: Sat Apr 25 2020 - 22:19:44 EST


26.04.2020 05:10, Dmitry Osipenko ÐÐÑÐÑ:
...
>> currently other Tegra host1x driver (drm) also does similar. Single
>> module for all Tegra SoCs.
>
> DRM driver has a proper separation of the sub-drivers where sub-driver
> won't load on unsupported hardware. The tegra-video driver should do the
> same, i.e. VI and CSI should be individual drivers (and not OPS). There
> could be a some common core, but for now it's not obvious to me what
> that core should be, maybe just the video.c.

Maybe video.c csi.c vi.c could be moved into a separate module, somewhat
like a common driver framework. Then the individual CSI/VI drivers will
use those common helpers.. Just a quick thought.