Re: [PATCH] ray_cs: use true,false for bool variable

[Jason Yan]

å 2020/4/26 18:27, Jason Yan åé:
> å 2020/4/26 17:47, Sergei Shtylyov åé:
> > Hello!
> >
> > On 26.04.2020 12:41, Jason Yan wrote:
> >
> > > Fix the following coccicheck warning:
> > >
> > > drivers/net/wireless/ray_cs.c:2797:5-14: WARNING: Comparison of 0/1 to
> > > bool variable
> > > drivers/net/wireless/ray_cs.c:2798:2-11: WARNING: Assignment of 0/1 to
> > > bool variable
> > >
> > > Signed-off-by: Jason Yan <yanaijie@xxxxxxxxxx>
> > > ---
> > > Â drivers/net/wireless/ray_cs.c | 4 ++--
> > > Â 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/net/wireless/ray_cs.c 
> > > b/drivers/net/wireless/ray_cs.c
> > > index c1d542bfa530..f9402424accd 100644
> > > --- a/drivers/net/wireless/ray_cs.c
> > > +++ b/drivers/net/wireless/ray_cs.c
> > > @@ -2794,8 +2794,8 @@ static int __init init_ray_cs(void)
> > > ÂÂÂÂÂ proc_create_data("driver/ray_cs/translate", 0200, NULL, 
> > > &int_proc_ops,
> > > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂ &translate);
> > > Â #endif
> > > -ÂÂÂ if (translate != 0)
> > > -ÂÂÂÂÂÂÂ translate = 1;
> > > +ÂÂÂ if (!translate)
> >
> > ÂÂÂ That inverts the original logic, no?
>
> Oh, yes.
>
> > > +ÂÂÂÂÂÂÂ translate = true;
> >
> > ÂÂÂ Actually, that whole comparison/assignment doesn't make sense, if 
> > we use bool...
>
> So may be we can do this:
>
> diff --git a/drivers/net/wireless/ray_cs.c b/drivers/net/wireless/ray_cs.c
> index c1d542bfa530..9ea695459342 100644
> --- a/drivers/net/wireless/ray_cs.c
> +++ b/drivers/net/wireless/ray_cs.c
> @@ -2794,8 +2794,7 @@ static int __init init_ray_cs(void)
>  ÂÂÂÂÂÂÂ proc_create_data("driver/ray_cs/translate", 0200, NULL, 
> &int_proc_ops,
>  ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ &translate);
>  Â#endif
> -ÂÂÂÂÂÂ if (translate != 0)
> -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂ translate = 1;
> +ÂÂÂÂÂÂ translate == !!translate;

Sorry, this should be:
		translate = !!translate;

>  ÂÂÂÂÂÂÂ return 0;
>  Â} /* init_ray_cs */
>
> > [...]
> >
> > MBR, Sergei
> >
> > .
>
>
> .