Re: [PATCH v3 3/3] ARM: dts: Add Caninos Loucos Labrador

[Andreas FÃrber]

Hi Matheus,

Am 23.04.20 um 17:20 schrieb Matheus Castello:
> Em 4/5/20 3:51 AM, Manivannan Sadhasivam escreveu:
> > On Fri, Mar 20, 2020 at 12:51:04AM -0300, Matheus Castello wrote:
> > > Add Device Trees for Caninos Loucos Labrador CoM and base board.
> > > Based on the work of Andreas FÃrber on Lemaker Guitar device tree.
> > >
> > > Signed-off-by: Matheus Castello <matheus@xxxxxxxxxxxxxxx>
> >
> > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
> >
> > Will queue the series for v5.8 once Andreas is happy with it.
>
> do you have any more concerns about these patches? Let me know.

I've reviewed the preceding two patches. This one here looks okay,

Reviewed-by: Andreas FÃrber <afaerber@xxxxxxx>

but see 2/3 - model here does contain M and your .dtsi is named -v2 - 
what's the difference to v1? If it's big enough to warrant a separate 
.dtsi, you should consider whether a versioned compatible string may be 
needed, too (likely in addition to, not instead of a generic one). No v1 
info on the website.

Thanks,
Andreas

--
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 NÃrnberg, Germany
GF: Felix ImendÃrffer
HRB 36809 (AG NÃrnberg)