Re: [PATCH v4 03/10] input: elants: remove unused axes

[Dmitry Osipenko]

26.04.2020 20:45, Dmitry Osipenko ÐÐÑÐÑ:
> 26.04.2020 20:29, MichaÅ MirosÅaw ÐÐÑÐÑ:
>> On Sun, Apr 26, 2020 at 07:35:47PM +0300, Dmitry Osipenko wrote:
>>> 26.04.2020 19:11, MichaÅ MirosÅaw ÐÐÑÐÑ:
>>>> Driver only ever reports MT events and input_mt_init_slots() sets up
>>>> emulated axes already.  Clear the capabilities not generated directly
>>>> and move MT axes setup, so they are visible by input_mt_init_slots().
>>>>
>>>> Signed-off-by: MichaÅ MirosÅaw <mirq-linux@xxxxxxxxxxxx>
>>>> Reviewed-by: Dmitry Osipenko <digetx@xxxxxxxxx>
>>>> Tested-by: Dmitry Osipenko <digetx@xxxxxxxxx>
>>>> ---
>>>> v4: reword commitmsg; reorder axis setup
>>>> ---
>>>
>>> Legacy pointer emulation doesn't work using v4. I think it will be
>>> better to drop this patch for now and add this hunk to the patch #4:
>>
>> Have you tried it together with the next patch? It adds
>> touchscreen_parse_properties() to initialize axes also from DT, and
>> should be equivalent to the hunk you proposed.
> 
> Yes, the touchscreen_parse_properties() takes bool multitouch for the
> argument, and thus, it needs to be applied to both MT/non-MT cases.
> 
> https://elixir.bootlin.com/linux/v5.7-rc2/source/drivers/input/touchscreen/of_touchscreen.c#L64
> 
>> [...]
>>> Maybe input_mt_init_slots() could be changed to set up all the
>>> properties that are needed for the legacy pointer, but I'm not 100% sure
>>> because not very familiar with that code. Perhaps Dmitry Torokhov could
>>> clarify?
>>
>> The code of input_mt_init_slots() looks like it does initialize the
>> properties needed. What does evtest return with and without the patches?

Oh wait, seems I messed up something while was applying the patches.
I'll try the v5 now.