Re: R: [PATCH v2 2/2] dt-bindings: opp: Fix wrong binding in qcom-nvmem-cpufreq

From: Viresh Kumar
Date: Sun Apr 26 2020 - 23:49:58 EST


On 25-04-20, 00:19, ansuelsmth@xxxxxxxxx wrote:
> > On Wed, Apr 22, 2020 at 3:12 PM Ansuel Smith <ansuelsmth@xxxxxxxxx>
> > wrote:
> > >
> > > Update binding to new generic name "operating-points-v2-qcom-cpu"
> > >
> > > Fixes: a8811ec764f9 ("cpufreq: qcom: Add support for krait based socs")
> > > Signed-off-by: Ansuel Smith <ansuelsmth@xxxxxxxxx>
> > > ---
> > > Documentation/devicetree/bindings/opp/qcom-nvmem-cpufreq.txt | 2
> > +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/opp/qcom-nvmem-
> > cpufreq.txt b/Documentation/devicetree/bindings/opp/qcom-nvmem-
> > cpufreq.txt
> > > index 64f07417ecfb..537e1774f589 100644
> > > --- a/Documentation/devicetree/bindings/opp/qcom-nvmem-cpufreq.txt
> > > +++ b/Documentation/devicetree/bindings/opp/qcom-nvmem-
> > cpufreq.txt
> > > @@ -19,7 +19,7 @@ In 'cpu' nodes:
> > >
> > > In 'operating-points-v2' table:
> > > - compatible: Should be
> > > - - 'operating-points-v2-kryo-cpu' for apq8096, msm8996, msm8974,
> > > + - 'operating-points-v2-qcom-cpu' for apq8096, msm8996,
> > msm8974,
> > > apq8064, ipq8064, msm8960 and ipq8074.
> >
> > This is not how you fix the backwards compatibility issue pointed out
> > on the Fixes reference.
> >
> > Rob
>
> Sorry but can you give some directive? Should I use the old binding and change
> the driver to use it instead of the new one (and drop it) ?

It is not about the name of the binding, you can rename it to whatever
you want. The kernel needs to keep supporting all the previous
bindings, so we can keep on changing the kernel but keep the same
bootloader (with earlier bindings).

--
viresh