Re: [PATCH 5/5] sysctl: pass kernel pointers to ->proc_handler

From: Christoph Hellwig
Date: Mon Apr 27 2020 - 01:34:53 EST


On Fri, Apr 24, 2020 at 12:06:50PM -0700, Andrey Ignatov wrote:
> > -
> > -#ifdef CONFIG_UCLAMP_TASK
>
> Decided to skim through the patch one last time to double-check the fix
> from previous iteration and found that this ifdef got lost below.
>
> > -extern int sysctl_sched_uclamp_handler(struct ctl_table *table, int write,
> > - void __user *buffer, size_t *lenp,
> > - loff_t *ppos);
> > -#endif

There is no need for ifdefs around prototypes that aren't used.