Re: [PATCH 1/3] arm64: dts: ti: am654: Add DSS node

[Tomi Valkeinen]

On 27/04/2020 13:08, Tero Kristo wrote:
> On 22/04/2020 12:15, Tomi Valkeinen wrote:
> > From: Jyri Sarha <jsarha@xxxxxx>
> >
> > Add DSS node to k3-am65-main.dtsi with labels for board specific
> > support and syscon node for oldi-io-ctrl.
> >
> > Signed-off-by: Jyri Sarha <jsarha@xxxxxx>
> > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx>
> > ---
> > Â arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 44 ++++++++++++++++++++++++
> > Â 1 file changed, 44 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> > index 11887c72f23a..7d1bc991708e 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> > @@ -287,6 +287,11 @@
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂ mux-reg-masks = <0x4080 0x3>, /* SERDES0 lane select */
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ <0x4090 0x3>; /* SERDES1 lane select */
> > ÂÂÂÂÂÂÂÂÂ };
> > +
> > +ÂÂÂÂÂÂÂ dss_oldi_io_ctrl: dss_oldi_io_ctrl@41E0 {
> > +ÂÂÂÂÂÂÂÂÂÂÂ compatible = "syscon";
> > +ÂÂÂÂÂÂÂÂÂÂÂ reg = <0x0000041E0 0x14>;
> > +ÂÂÂÂÂÂÂ };
> > ÂÂÂÂÂ };
> > ÂÂÂÂÂ dwc3_0: dwc3@4000000 {
> > @@ -746,4 +751,43 @@
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂ };
> > ÂÂÂÂÂÂÂÂÂ };
> > ÂÂÂÂÂ };
> > +
> > +ÂÂÂ dss: dss@04a00000 {
> > +ÂÂÂÂÂÂÂ compatible = "ti,am65x-dss";
> > +ÂÂÂÂÂÂÂ reg =ÂÂÂ <0x0 0x04a00000 0x0 0x1000>, /* common */
> > +ÂÂÂÂÂÂÂÂÂÂÂ <0x0 0x04a02000 0x0 0x1000>, /* vidl1 */
> > +ÂÂÂÂÂÂÂÂÂÂÂ <0x0 0x04a06000 0x0 0x1000>, /* vid */
> > +ÂÂÂÂÂÂÂÂÂÂÂ <0x0 0x04a07000 0x0 0x1000>, /* ovr1 */
> > +ÂÂÂÂÂÂÂÂÂÂÂ <0x0 0x04a08000 0x0 0x1000>, /* ovr2 */
> > +ÂÂÂÂÂÂÂÂÂÂÂ <0x0 0x04a0a000 0x0 0x1000>, /* vp1 */
> > +ÂÂÂÂÂÂÂÂÂÂÂ <0x0 0x04a0b000 0x0 0x1000>; /* vp2 */
> > +ÂÂÂÂÂÂÂ reg-names = "common", "vidl1", "vid",
> > +ÂÂÂÂÂÂÂÂÂÂÂ "ovr1", "ovr2", "vp1", "vp2";
> > +
> > +ÂÂÂÂÂÂÂ ti,am65x-oldi-io-ctrl = <&dss_oldi_io_ctrl>;
> > +
> > +ÂÂÂÂÂÂÂ power-domains = <&k3_pds 67 TI_SCI_PD_EXCLUSIVE>;
> > +
> > +ÂÂÂÂÂÂÂ clocks =ÂÂÂ <&k3_clks 67 1>,
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ <&k3_clks 216 1>,
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ <&k3_clks 67 2>;
> > +ÂÂÂÂÂÂÂ clock-names = "fck", "vp1", "vp2";
> > +
> > +ÂÂÂÂÂÂÂ /*
> > +ÂÂÂÂÂÂÂÂ * Set vp2 clk (DPI_1_IN_CLK) mux to PLL4 via
> > +ÂÂÂÂÂÂÂÂ * DIV1. See "Figure 12-3365. DSS Integration"
> > +ÂÂÂÂÂÂÂÂ * in AM65x TRM for details.
> > +ÂÂÂÂÂÂÂÂ */
> > +ÂÂÂÂÂÂÂ assigned-clocks = <&k3_clks 67 2>;
> > +ÂÂÂÂÂÂÂ assigned-clock-parents = <&k3_clks 67 5>;
> > +
> > +ÂÂÂÂÂÂÂ interrupts = <GIC_SPI 166 IRQ_TYPE_EDGE_RISING>;
> > +
> > +ÂÂÂÂÂÂÂ status = "disabled";
>
> Any reason why the node is disabled? Are you planning to enable it somewhere later on, or is that 
> left for the user to do?

It's enabled in board DT files or DT overlays which add a display and the DT graph for the 
connections. Having DSS driver probe without any displays is a waste of resources.

 Tomi

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki