Re: [PATCH v20 02/17] leds: Add multicolor ID to the color ID list

From: Dan Murphy
Date: Mon Apr 27 2020 - 13:18:29 EST


Pavel

On 4/25/20 2:52 PM, Pavel Machek wrote:
On Thu 2020-04-23 10:55:09, Dan Murphy wrote:
Add a new color ID that is declared as MULTICOLOR as with the
multicolor framework declaring a definitive color is not accurate
as the node can contain multiple colors.

Signed-off-by: Dan Murphy <dmurphy@xxxxxx>
Please merge with previous patch, and you can keep reviews.

Not sure we should do that. The previous patches deals directly with the bindings and this is code.

I thought the rule was to keep bindings and code separated.

It made sense to squash the bindings header patch to the bindings document patch but it does not make sense to squash this patch to the bindings.

Please let me know if you want me to proceed with the squash.

Dan