Re: [PATCH v20 12/17] leds: lp55xx: Add multicolor framework support to lp55xx

[Dan Murphy]

Jacek

On 4/26/20 11:07 AM, Jacek Anaszewski wrote:
> Hi Dan,
>
> One nit below.
>
> On 4/23/20 5:55 PM, Dan Murphy wrote:
> > Add multicolor framework support for the lp55xx family.
> >
> > Signed-off-by: Dan Murphy <dmurphy@xxxxxx>
> > ---
> > Â drivers/leds/KconfigÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |ÂÂ 1 +
> > Â drivers/leds/leds-lp5521.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |Â 14 +-
> > Â drivers/leds/leds-lp5523.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |Â 14 +-
> > Â drivers/leds/leds-lp5562.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |Â 13 +-
> > Â drivers/leds/leds-lp55xx-common.cÂÂÂÂÂÂÂÂ | 178 +++++++++++++++++++---
> > Â drivers/leds/leds-lp55xx-common.hÂÂÂÂÂÂÂÂ |Â 11 +-
> > Â drivers/leds/leds-lp8501.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |Â 14 +-
> > Â include/linux/platform_data/leds-lp55xx.h |ÂÂ 8 +
> > Â 8 files changed, 207 insertions(+), 46 deletions(-)
> [...]
> > diff --git a/drivers/leds/leds-lp55xx-common.h 
> > b/drivers/leds/leds-lp55xx-common.h
> > index b9b1041e8143..a9d7ba3f2fd1 100644
> > --- a/drivers/leds/leds-lp55xx-common.h
> > +++ b/drivers/leds/leds-lp55xx-common.h
> > @@ -12,6 +12,8 @@
> > Â #ifndef _LEDS_LP55XX_COMMON_H
> > Â #define _LEDS_LP55XX_COMMON_H
> > Â +#include <linux/led-class-multicolor.h>
> > +
> > Â enum lp55xx_engine_index {
> > ÂÂÂÂÂ LP55XX_ENGINE_INVALID,
> > ÂÂÂÂÂ LP55XX_ENGINE_1,
> > @@ -109,6 +111,9 @@ struct lp55xx_device_config {
> > ÂÂÂÂÂ /* access brightness register */
> > ÂÂÂÂÂ int (*brightness_fn)(struct lp55xx_led *led);
> > Â +ÂÂÂ /* perform brightness value to multiple LEDs */
> > +ÂÂÂ int (*multicolor_brightness_fn)(struct lp55xx_led *led);
>
> Isn't some word missing here? IMO it should be rephrased.
> Maybe "write multi color brightness to hw" ?
But brightness_fn does not say write_brightness_fn so I think this would 
look weird to add write to the function name

Dan