Re: [PATCH v2 08/12] mtd: rawnand: stm32_fmc2: use FIELD_PREP/FIELD_GET macros

From: Miquel Raynal
Date: Mon Apr 27 2020 - 14:50:55 EST


Hello,

Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx> wrote on Thu, 16 Apr
2020 21:45:13 +0200:

> On Wed, 15 Apr 2020 17:57:32 +0200
> Christophe Kerello <christophe.kerello@xxxxxx> wrote:
>
> > This patch removes custom macros and uses FIELD_PREP and FIELD_GET macros.
>
> Oh, nice. I didn't know about these macros. This could have saved me
> from defining a whole bunch of setters/getters in driver code...
>
>

Love these too! I will definitely use them in the future.

Reviewed-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>

Thanks,
MiquÃl