Re: [PATCH] firmware: stratix10-svc: Drop unnecessary checking for and populating /firmware/ node

[Richard Gong]

Hi Sudeep,

In our dts, firmware is not under root node. You can refer to 
arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi for details.

This is why we need check and populate firmware node.

Regards,
Richard

On 4/23/20 3:11 AM, Sudeep Holla wrote:
> On Wed, Apr 22, 2020 at 04:50:00PM -0500, Richard Gong wrote:
> > Hi Sudeep,
> >
> > I tried and couldn't load stratix10-svc driver with your patch on kernel
> > 5.6.
>
> What exactly do you mean by not loading stratix10-svc driver ?
> This patch doesn't change that part, the driver should still get loaded.
> The change may affect probing part if for some reason the devices for
> nodes under firmware are not populated which I still can't understand.
>
> Do you see any change under i/sys/devices/platform/firmware\:* with
> and without this change ?
>
> Lots of drivers removed the code similar to this patch after the Commit
> 3aa0582fdb82 ("of: platform: populate /firmware/ node from
> of_platform_default_populate_init()") and continue to work fine. I am
> interested to see what is different in stratix10-svc.
>
> --
> Regards,
> Sudeep