Re: [PATCH 2/3] mtd: lpddr: Replace printk with pr_notice

From: Joe Perches
Date: Mon Apr 27 2020 - 15:01:09 EST


On Mon, 2020-04-27 at 14:03 -0500, Gustavo A. R. Silva wrote:
> pr_notice is preferred over printk.

So is coalescing formats

? diff --git a/include/linux/mtd/pfow.h b/include/linux/mtd/pfow.h
[]
> @@ -127,31 +127,31 @@ static inline void print_drs_error(unsigned dsr)
> int prog_status = (dsr & DSR_RPS) >> 8;
>
> if (!(dsr & DSR_AVAILABLE))
> - printk(KERN_NOTICE"DSR.15: (0) Device not Available\n");
> + pr_notice("DSR.15: (0) Device not Available\n");
> if ((prog_status & 0x03) == 0x03)
> - printk(KERN_NOTICE"DSR.9,8: (11) Attempt to program invalid "
> + pr_notice("DSR.9,8: (11) Attempt to program invalid "
> "half with 41h command\n");

pr_notice("DSR.9,8: (11) Attempt to program invalid half with 41h command\n");

etc...