Re: [PATCH 1/2] drivers/clocksource/timer-of: Remove __init markings

[Saravana Kannan]

On Mon, Apr 27, 2020 at 10:13 AM Daniel Lezcano
<daniel.lezcano@xxxxxxxxxx> wrote:
>
> On 13/04/2020 04:55, Baolin Wang wrote:
> > Hi Daniel,
> >
> > On Tue, Mar 24, 2020 at 1:59 PM Baolin Wang <baolin.wang7@xxxxxxxxx> wrote:
> >>
> >> From: Saravana Kannan <saravanak@xxxxxxxxxx>
> >>
> >> This allows timer drivers to be compiled as modules.
> >>
> >> Signed-off-by: Saravana Kannan <saravanak@xxxxxxxxxx>
> >> Signed-off-by: Baolin Wang <baolin.wang7@xxxxxxxxx>
> >
> > Do you have any comments for this patch set? Thanks.
>
> If my understanding is correct, this patch is part of the GKI picture
> where hardware drivers are converted to modules.
>
> But do we really want to convert timer drivers to modules ?
>
> Is the core time framework able to support that (eg. load + unload )

So this will mainly be used for secondary timers that the system
supports. Not for the main one that's set up during early boot for
sched timer to work. For the primary timer during boot up, we still
expect that to be the default ARM timer and don't want/expect that to
be a module (it can't be).

-Saravana