Re: [PATCH] net/sonic: Fix a resource leak in an error handling path in 'jazz_sonic_probe()'

From: David Miller
Date: Mon Apr 27 2020 - 15:08:03 EST


From: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
Date: Mon, 27 Apr 2020 08:18:03 +0200

> A call to 'dma_alloc_coherent()' is hidden in 'sonic_alloc_descriptors()',
> called from 'sonic_probe1()'.
>
> This is correctly freed in the remove function, but not in the error
> handling path of the probe function.
> Fix it and add the missing 'dma_free_coherent()' call.
>
> While at it, rename a label in order to be slightly more informative.
>
> Fixes: efcce839360f ("[PATCH] macsonic/jazzsonic network drivers update")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>

Applied, thanks.