RE: [PATCH] ARM: dts: r8a7743: Add missing compatible strings for iic3 node

[Prabhakar Mahadev Lad]

Hi Geert,

> -----Original Message-----
> From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Sent: 27 April 2020 21:00
> To: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> Cc: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>; Magnus Damm <magnus.damm@xxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>;
> Lad Prabhakar <prabhakar.csengg@xxxxxxxxx>; open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
> <devicetree@xxxxxxxxxxxxxxx>; Linux-Renesas <linux-renesas-soc@xxxxxxxxxxxxxxx>; Linux Kernel Mailing List <linux-
> kernel@xxxxxxxxxxxxxxx>
> Subject: Re: [PATCH] ARM: dts: r8a7743: Add missing compatible strings for iic3 node
>
> Hi Prabhakar,
>
> On Mon, Apr 27, 2020 at 6:20 PM Lad Prabhakar
> <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> wrote:
> > Add missing compatible strings "renesas,rcar-gen2-iic" and
> > "renesas,rmobile-iic" to iic3 node of r8a7743 SoC.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>
> Thanks for your patch!
>
> > --- a/arch/arm/boot/dts/r8a7743.dtsi
> > +++ b/arch/arm/boot/dts/r8a7743.dtsi
> > @@ -551,7 +551,9 @@
> >                         /* doesn't need pinmux */
> >                         #address-cells = <1>;
> >                         #size-cells = <0>;
> > -                       compatible = "renesas,iic-r8a7743";
> > +                       compatible = "renesas,iic-r8a7743",
> > +                                    "renesas,rcar-gen2-iic",
> > +                                    "renesas,rmobile-iic";
> >                         reg = <0 0xe60b0000 0 0x425>;
> >                         interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>;
> >                         clocks = <&cpg CPG_MOD 926>;
>
> This was intentional, cfr. commit 072b817589b17660 ("ARM: dts: r8a7743:
> Remove generic compatible string from iic3"), and my review comments on
> "[PATCH 02/22] ARM: dts: r8a7744: Add I2C and IIC support"
> (https://lore.kernel.org/linux-devicetree/CAMuHMdVt2DDQJ9Ud6i=GWAeWW0TdpF5xiCxtRiv0dZTGCPEt8A@xxxxxxxxxxxxxx/).
>
> The note at the bottom of Section 45.1 of the RZ/G1 Hardware User's
> Manual says: "Automatic transmission for PMIC control (DVFS) is not
> available ...".
>
Completely missed that, thank you for pointing it out.

Cheers,
--Prabhakar

> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds


Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647