Re: [PATCH] arm64: dts: allwinner: h6: Use dedicated CPU OPP table for Tanix TX6

[ClÃment PÃron]

Hi Maxime,

On Tue, 28 Apr 2020 at 09:52, Maxime Ripard <maxime@xxxxxxxxxx> wrote:
>
> On Sun, Apr 26, 2020 at 02:17:09PM +0200, ClÃment PÃron wrote:
> > Tanix TX6 has a fixed regulator. As DVFS is instructed to change
> > voltage to meet OPP table. The DVFS is not working as expected.
> >
> > Introduce a dedicated OPP Table where voltage are equals to
> > the fixed regulator.
> >
> > Reported-by: Piotr Oniszczuk <warpme@xxxxx>
> > Fixes: add1e27fb703 ("arm64: dts: allwinner: h6: Enable CPU opp tables for Tanix TX6")
> > Signed-off-by: ClÃment PÃron <peron.clem@xxxxxxxxx>
>
> I'm not really a big fan of duplicating the OPPs, since that would make an
> update of those very likely to be overlooked for that particular board (and
> since it's a board that not a lot of people have, it would be harder to notice
> too).
>
> IIRC, removing the cpu-supply property should work as well?
Yes it would works also the OPP will provide a dummy regulator.

But as it has been introduced and there is a cpu regulator in the real life.
I thought it was a bit a hack to just remove it but as you wish.

Regards,
Clement



>
> Maxime