Re: [PATCH 4/7] perf bpf: Decouple creating the evlist from adding the SB event

[Jiri Olsa]

On Mon, Apr 27, 2020 at 06:19:32PM -0300, Arnaldo Carvalho de Melo wrote:
> From: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> 
> Renaming bpf_event__add_sb_event() to evlist__add_sb_event() and
> requiring that the evlist be allocated beforehand.

hum, this seems to be done in previous patch, maybe you
need to squash this with the previous one?

jirka

> 
> This will allow using the same side band thread and evlist to be used
> for multiple purposes in addition to react to PERF_RECORD_BPF_EVENT soon
> after they are generated.
> 
> Cc: Adrian Hunter <adrian.hunter@xxxxxxxxx>
> Cc: Jiri Olsa <jolsa@xxxxxxxxxx>
> Cc: Namhyung Kim <namhyung@xxxxxxxxxx>
> Cc: Song Liu <songliubraving@xxxxxx>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> ---
>  tools/perf/util/bpf-event.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/bpf-event.h b/tools/perf/util/bpf-event.h
> index 2c7a50509659..68f315c3df5b 100644
> --- a/tools/perf/util/bpf-event.h
> +++ b/tools/perf/util/bpf-event.h
> @@ -45,7 +45,7 @@ static inline int machine__process_bpf(struct machine *machine __maybe_unused,
>  	return 0;
>  }
>  
> -static inline int evlist__add_bpf_sb_event(struct evlist **evlist __maybe_unused,
> +static inline int evlist__add_bpf_sb_event(struct evlist *evlist __maybe_unused,
>  					   struct perf_env *env __maybe_unused)
>  {
>  	return 0;
> -- 
> 2.21.1
>