Re: [PATCH 02/13] arm: dts: s5pv210: fascinate4g: Add sleep GPIO configuration

From: Krzysztof Kozlowski
Date: Tue Apr 28 2020 - 06:02:53 EST

Next message: Andy Shevchenko: "Re: [RFC][PATCH] serial: amba-pl011: Make sure we initialize the port.lock spinlock"
Previous message: Jessica Yu: "Re: [PATCH v3] module: Allow to disable modsign in kernel cmdline"
In reply to: Jonathan Bakker: "[PATCH 02/13] arm: dts: s5pv210: fascinate4g: Add sleep GPIO configuration"
Next in thread: Jonathan Bakker: "Re: [PATCH 02/13] arm: dts: s5pv210: fascinate4g: Add sleep GPIO configuration"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Sun, Apr 26, 2020 at 11:35:53AM -0700, Jonathan Bakker wrote:
> In order to minimize leakage current during sleep, set a config
> for sleep GPIOs.
>
> Signed-off-by: Jonathan Bakker <xc-racer2@xxxxxxx>
> ---
> arch/arm/boot/dts/s5pv210-fascinate4g.dts | 242 ++++++++++++++++++++++
> 1 file changed, 242 insertions(+)
>
> diff --git a/arch/arm/boot/dts/s5pv210-fascinate4g.dts b/arch/arm/boot/dts/s5pv210-fascinate4g.dts
> index 07a8d9bbe5b8..94dcb9b64b9a 100644
> --- a/arch/arm/boot/dts/s5pv210-fascinate4g.dts
> +++ b/arch/arm/boot/dts/s5pv210-fascinate4g.dts
> @@ -36,3 +36,245 @@
> };
> };
> };
> +
> +&pinctrl0 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&sleep_cfg>;
> +
> + sleep_cfg: sleep-cfg {
> + PIN_SLP(gpa0-0, PREV, NONE);
> + PIN_SLP(gpa0-1, PREV, NONE);
> + PIN_SLP(gpa0-2, PREV, NONE);
> + PIN_SLP(gpa0-3, OUT1, NONE);

I would be happy to see some reasoning why certain pins have disabled
pull down (e.g. they are not connected or you use the same configuration
as running one) and why you set them as output.

> + PIN_SLP(gpa0-4, PREV, NONE);
> + PIN_SLP(gpa0-5, PREV, NONE);
> + PIN_SLP(gpa0-6, PREV, NONE);
> + PIN_SLP(gpa0-7, PREV, NONE);
> +
> + PIN_SLP(gpa1-0, INPUT, DOWN);
> + PIN_SLP(gpa1-1, OUT0, NONE);
> + PIN_SLP(gpa1-2, INPUT, DOWN);
> + PIN_SLP(gpa1-3, OUT0, NONE);
> +
> + PIN_SLP(gpb-0, OUT0, NONE);
> + PIN_SLP(gpb-1, OUT1, NONE);
> + PIN_SLP(gpb-2, OUT0, NONE);
> + PIN_SLP(gpb-3, PREV, NONE);
> + PIN_SLP(gpb-4, INPUT, NONE);
> + PIN_SLP(gpb-5, PREV, NONE);
> + PIN_SLP(gpb-6, INPUT, DOWN);
> + PIN_SLP(gpb-7, OUT0, NONE);
> +
> + PIN_SLP(gpc0-0, OUT0, NONE);
> + PIN_SLP(gpc0-1, INPUT, DOWN);
> + PIN_SLP(gpc0-2, OUT0, NONE);
> + PIN_SLP(gpc0-3, INPUT, DOWN);
> + PIN_SLP(gpc0-4, OUT0, NONE);
> +
> + PIN_SLP(gpc1-0, INPUT, DOWN);
> + PIN_SLP(gpc1-1, INPUT, DOWN);
> + PIN_SLP(gpc1-2, INPUT, DOWN);
> + PIN_SLP(gpc1-3, INPUT, DOWN);
> + PIN_SLP(gpc1-4, INPUT, DOWN);
> +
> + PIN_SLP(gpd0-0, INPUT, DOWN);
> + PIN_SLP(gpd0-1, OUT0, NONE);
> + PIN_SLP(gpd0-2, INPUT, DOWN);
> + PIN_SLP(gpd0-3, INPUT, DOWN);
> +
> + PIN_SLP(gpd1-0, INPUT, NONE);
> + PIN_SLP(gpd1-1, INPUT, NONE);
> + PIN_SLP(gpd1-2, INPUT, DOWN);
> + PIN_SLP(gpd1-3, INPUT, DOWN);
> + PIN_SLP(gpd1-4, INPUT, DOWN);
> + PIN_SLP(gpd1-5, INPUT, DOWN);
> +
> + PIN_SLP(gpe0-0, INPUT, DOWN);
> + PIN_SLP(gpe0-1, INPUT, DOWN);
> + PIN_SLP(gpe0-2, INPUT, DOWN);
> + PIN_SLP(gpe0-3, INPUT, DOWN);
> + PIN_SLP(gpe0-4, INPUT, DOWN);
> + PIN_SLP(gpe0-5, INPUT, DOWN);
> + PIN_SLP(gpe0-6, INPUT, DOWN);
> + PIN_SLP(gpe0-7, INPUT, DOWN);
> +
> + PIN_SLP(gpe1-0, INPUT, DOWN);
> + PIN_SLP(gpe1-1, INPUT, DOWN);
> + PIN_SLP(gpe1-2, INPUT, DOWN);
> + PIN_SLP(gpe1-3, OUT0, NONE);
> + PIN_SLP(gpe1-4, INPUT, DOWN);
> +
> + PIN_SLP(gpf0-0, OUT0, NONE);
> + PIN_SLP(gpf0-1, OUT0, NONE);
> + PIN_SLP(gpf0-2, OUT0, NONE);
> + PIN_SLP(gpf0-3, OUT0, NONE);
> + PIN_SLP(gpf0-4, OUT0, NONE);
> + PIN_SLP(gpf0-5, OUT0, NONE);
> + PIN_SLP(gpf0-6, OUT0, NONE);
> + PIN_SLP(gpf0-7, OUT0, NONE);
> +
> + PIN_SLP(gpf1-0, OUT0, NONE);
> + PIN_SLP(gpf1-1, OUT0, NONE);
> + PIN_SLP(gpf1-2, OUT0, NONE);
> + PIN_SLP(gpf1-3, OUT0, NONE);
> + PIN_SLP(gpf1-4, OUT0, NONE);
> + PIN_SLP(gpf1-5, OUT0, NONE);
> + PIN_SLP(gpf1-6, OUT0, NONE);
> + PIN_SLP(gpf1-7, OUT0, NONE);
> +
> + PIN_SLP(gpf2-0, OUT0, NONE);
> + PIN_SLP(gpf2-1, OUT0, NONE);
> + PIN_SLP(gpf2-2, OUT0, NONE);
> + PIN_SLP(gpf2-3, OUT0, NONE);
> + PIN_SLP(gpf2-4, OUT0, NONE);
> + PIN_SLP(gpf2-5, OUT0, NONE);
> + PIN_SLP(gpf2-6, OUT0, NONE);
> + PIN_SLP(gpf2-7, OUT0, NONE);
> +
> + PIN_SLP(gpf3-0, OUT0, NONE);
> + PIN_SLP(gpf3-1, OUT0, NONE);
> + PIN_SLP(gpf3-2, OUT0, NONE);
> + PIN_SLP(gpf3-3, OUT0, NONE);
> + PIN_SLP(gpf3-4, PREV, NONE);
> + PIN_SLP(gpf3-5, INPUT, DOWN);
> +
> + PIN_SLP(gpg0-0, INPUT, DOWN);
> + PIN_SLP(gpg0-1, INPUT, DOWN);
> + PIN_SLP(gpg0-2, INPUT, NONE);
> + PIN_SLP(gpg0-3, INPUT, DOWN);
> + PIN_SLP(gpg0-4, INPUT, DOWN);
> + PIN_SLP(gpg0-5, INPUT, DOWN);
> + PIN_SLP(gpg0-6, INPUT, DOWN);
> +
> + PIN_SLP(gpg1-0, OUT0, NONE);
> + PIN_SLP(gpg1-1, OUT1, NONE);
> + PIN_SLP(gpg1-2, PREV, NONE);
> + PIN_SLP(gpg1-3, OUT1, NONE);
> + PIN_SLP(gpg1-4, OUT1, NONE);
> + PIN_SLP(gpg1-5, OUT1, NONE);
> + PIN_SLP(gpg1-6, OUT1, NONE);
> +
> + PIN_SLP(gpg2-0, OUT0, NONE);
> + PIN_SLP(gpg2-1, OUT0, NONE);
> + PIN_SLP(gpg2-2, INPUT, NONE);
> + PIN_SLP(gpg2-3, OUT0, NONE);
> + PIN_SLP(gpg2-4, OUT0, NONE);
> + PIN_SLP(gpg2-5, OUT0, NONE);
> + PIN_SLP(gpg2-6, OUT0, NONE);
> +
> + PIN_SLP(gpg3-0, PREV, UP);
> + PIN_SLP(gpg3-1, PREV, UP);
> + PIN_SLP(gpg3-2, INPUT, NONE);
> + PIN_SLP(gpg3-3, INPUT, DOWN);
> + PIN_SLP(gpg3-4, OUT0, NONE);
> + PIN_SLP(gpg3-5, OUT0, NONE);
> + PIN_SLP(gpg3-6, INPUT, DOWN);
> +
> + PIN_SLP(gpi-0, PREV, NONE);

No such name. Did you mean gpgi?

> + PIN_SLP(gpi-1, INPUT, DOWN);
> + PIN_SLP(gpi-2, PREV, NONE);
> + PIN_SLP(gpi-3, PREV, NONE);
> + PIN_SLP(gpi-4, PREV, NONE);
> + PIN_SLP(gpi-5, INPUT, DOWN);
> + PIN_SLP(gpi-6, INPUT, DOWN);
> +
> + PIN_SLP(gpj0-0, INPUT, NONE);
> + PIN_SLP(gpj0-1, INPUT, NONE);
> + PIN_SLP(gpj0-2, INPUT, NONE);
> + PIN_SLP(gpj0-3, INPUT, NONE);
> + PIN_SLP(gpj0-4, INPUT, NONE);
> + PIN_SLP(gpj0-5, INPUT, DOWN);
> + PIN_SLP(gpj0-6, OUT0, NONE);
> + PIN_SLP(gpj0-7, INPUT, NONE);
> +
> + PIN_SLP(gpj1-0, OUT1, NONE);
> + PIN_SLP(gpj1-1, OUT0, NONE);
> + PIN_SLP(gpj1-2, INPUT, DOWN);
> + PIN_SLP(gpj1-3, PREV, NONE);
> + PIN_SLP(gpj1-4, PREV, NONE);
> + PIN_SLP(gpj1-5, OUT0, NONE);
> +
> + PIN_SLP(gpj2-0, INPUT, DOWN);
> + PIN_SLP(gpj2-1, INPUT, DOWN);
> + PIN_SLP(gpj2-2, OUT0, NONE);
> + PIN_SLP(gpj2-3, INPUT, DOWN);
> + PIN_SLP(gpj2-4, INPUT, DOWN);
> + PIN_SLP(gpj2-5, PREV, NONE);
> + PIN_SLP(gpj2-6, PREV, NONE);
> + PIN_SLP(gpj2-7, INPUT, DOWN);
> +
> + PIN_SLP(gpj3-0, INPUT, NONE);
> + PIN_SLP(gpj3-1, INPUT, NONE);
> + PIN_SLP(gpj3-2, OUT0, NONE);
> + PIN_SLP(gpj3-3, INPUT, DOWN);
> + PIN_SLP(gpj3-4, INPUT, NONE);
> + PIN_SLP(gpj3-5, INPUT, NONE);
> + PIN_SLP(gpj3-6, INPUT, NONE);
> + PIN_SLP(gpj3-7, INPUT, NONE);
> +
> + PIN_SLP(gpj4-0, INPUT, NONE);
> + PIN_SLP(gpj4-1, INPUT, DOWN);
> + PIN_SLP(gpj4-2, PREV, NONE);
> + PIN_SLP(gpj4-3, INPUT, NONE);
> + PIN_SLP(gpj4-4, INPUT, DOWN);
> +
> + PIN_SLP(mp01-0, OUT1, NONE);
> + PIN_SLP(mp01-1, OUT0, NONE);
> + PIN_SLP(mp01-2, INPUT, DOWN);
> + PIN_SLP(mp01-3, INPUT, DOWN);
> + PIN_SLP(mp01-4, OUT1, NONE);
> + PIN_SLP(mp01-5, INPUT, DOWN);
> + PIN_SLP(mp01-6, INPUT, DOWN);
> + PIN_SLP(mp01-7, INPUT, DOWN);
> +
> + PIN_SLP(mp02-0, INPUT, DOWN);
> + PIN_SLP(mp02-1, INPUT, DOWN);
> + PIN_SLP(mp02-2, INPUT, NONE);
> + PIN_SLP(mp02-3, INPUT, DOWN);
> +
> + PIN_SLP(mp03-0, INPUT, DOWN);
> + PIN_SLP(mp03-1, INPUT, DOWN);
> + PIN_SLP(mp03-2, OUT1, NONE);
> + PIN_SLP(mp03-3, OUT0, NONE);
> + PIN_SLP(mp03-4, INPUT, NONE);
> + PIN_SLP(mp03-5, OUT0, NONE);
> + PIN_SLP(mp03-6, INPUT, DOWN);
> + PIN_SLP(mp03-7, INPUT, DOWN);
> +
> + PIN_SLP(mp04-0, INPUT, DOWN);
> + PIN_SLP(mp04-1, OUT0, NONE);
> + PIN_SLP(mp04-2, INPUT, DOWN);
> + PIN_SLP(mp04-3, OUT0, NONE);
> + PIN_SLP(mp04-4, INPUT, DOWN);
> + PIN_SLP(mp04-5, INPUT, DOWN);
> + PIN_SLP(mp04-6, OUT0, NONE);
> + PIN_SLP(mp04-7, INPUT, DOWN);
> +
> + PIN_SLP(mp05-0, INPUT, NONE);
> + PIN_SLP(mp05-1, INPUT, NONE);
> + PIN_SLP(mp05-2, INPUT, NONE);
> + PIN_SLP(mp05-3, INPUT, NONE);
> + PIN_SLP(mp05-4, INPUT, DOWN);
> + PIN_SLP(mp05-5, OUT0, NONE);
> + PIN_SLP(mp05-6, INPUT, DOWN);
> + PIN_SLP(mp05-7, PREV, NONE);
> +
> + PIN_SLP(mp06-0, INPUT, DOWN);
> + PIN_SLP(mp06-1, INPUT, DOWN);
> + PIN_SLP(mp06-2, INPUT, DOWN);
> + PIN_SLP(mp06-3, INPUT, DOWN);
> + PIN_SLP(mp06-4, INPUT, DOWN);
> + PIN_SLP(mp06-5, INPUT, DOWN);
> + PIN_SLP(mp06-6, INPUT, DOWN);
> + PIN_SLP(mp06-7, INPUT, DOWN);
> +
> + PIN_SLP(mp07-0, INPUT, DOWN);
> + PIN_SLP(mp07-1, INPUT, DOWN);
> + PIN_SLP(mp07-2, INPUT, DOWN);
> + PIN_SLP(mp07-3, INPUT, DOWN);
> + PIN_SLP(mp07-4, INPUT, DOWN);
> + PIN_SLP(mp07-5, INPUT, DOWN);
> + PIN_SLP(mp07-6, INPUT, DOWN);
> + PIN_SLP(mp07-7, INPUT, DOWN);
> + };

What about gphX?

Best regards,
Krzysztof

> +};
> --
> 2.20.1
>

Next message: Andy Shevchenko: "Re: [RFC][PATCH] serial: amba-pl011: Make sure we initialize the port.lock spinlock"
Previous message: Jessica Yu: "Re: [PATCH v3] module: Allow to disable modsign in kernel cmdline"
In reply to: Jonathan Bakker: "[PATCH 02/13] arm: dts: s5pv210: fascinate4g: Add sleep GPIO configuration"
Next in thread: Jonathan Bakker: "Re: [PATCH 02/13] arm: dts: s5pv210: fascinate4g: Add sleep GPIO configuration"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]