Re: [PATCH 1/6] iio: chemical: scd30: add core driver
From: Andy Shevchenko
Date: Tue Apr 28 2020 - 06:17:00 EST
On Tue, Apr 28, 2020 at 10:57 AM Tomasz Duszynski
<tomasz.duszynski@xxxxxxxxxxx> wrote:
>
> On Sat, Apr 25, 2020 at 09:52:25PM +0300, Andy Shevchenko wrote:
> > On Sat, Apr 25, 2020 at 9:42 PM Tomasz Duszynski
> > <tomasz.duszynski@xxxxxxxxxxx> wrote:
> > > On Sat, Apr 25, 2020 at 02:43:35PM +0300, Andy Shevchenko wrote:
> > > > On Fri, Apr 24, 2020 at 10:05 PM Tomasz Duszynski
> > > > <tomasz.duszynski@xxxxxxxxxxx> wrote:
> > > > > On Wed, Apr 22, 2020 at 10:49:44PM +0300, Andy Shevchenko wrote:
> > > > > > On Wed, Apr 22, 2020 at 5:22 PM Tomasz Duszynski
> > > > > > <tomasz.duszynski@xxxxxxxxxxx> wrote:
> >
> > ...
> >
> > > > > As for ABI that's in
> > > > > a separate patch.
> > > >
> > > > It's not good from bisectability point of view. If by some reason this
> > > > patch or documentation patch gets reverted, the other one will be
> > > > dangling.
> > > > Please, unify them.
> > > >
> > >
> > > Huh? Reverting core and leaving leftovers would be wrong and pointless.
> >
> > Exactly my point why it should be one patch. To secure impossibility
> > to do pointless reverts.
> >
>
> But the same applies to other driver parts like i2c or serial
> interfaces. I don't buy it.
They won't compile without core driver, right? Absence of the
documentation OTOH doesn't prevent build.
--
With Best Regards,
Andy Shevchenko