Re: [PATCH v5 3/8] usb: mausb_host: HCD initialization

[Greg KH]

On Sat, Apr 25, 2020 at 11:19:49AM +0200, vladimir.stankovic@xxxxxxxxxxxxxxx wrote:
> +static long mausb_ioctl(struct file *file, unsigned int ioctl_func,
> +			unsigned long ioctl_buffer)
> +{
> +	return 0;
> +}
> +

Why do you have an ioctl that does nothing?  Same for the other
functions that just return "success", if you don't do anything in them,
don't declare them please.



> +int mausb_init_hcd(void)
> +{
> +	int retval;
> +
> +	retval = register_chrdev(0, DEVICE_NAME, &mausb_fops);

But you already have a chardev?  Why use another one?

I don't understand the need for these, it's not obvious at all, please
provide a lot more information on what is going on with these userspace
facing interfaces please.

thanks,

greg k-h