Re: [PATCH] pinctrl: remove unused 'pwm37_pins'

[Jason Yan]

å 2020/4/28 19:30, Manivannan Sadhasivam åé:
> On Tue, Apr 28, 2020 at 11:58:01AM +0200, Linus Walleij wrote:
> > On Fri, Apr 17, 2020 at 10:54 AM Jason Yan <yanaijie@xxxxxxxxxx> wrote:
> >
> > > Fix the following gcc warning:
> > >
> > > drivers/pinctrl/pinctrl-bm1880.c:263:27: warning: âpwm37_pinsâ defined
> > > but not used [-Wunused-const-variable=]
> > >   static const unsigned int pwm37_pins[] = { 110 };
> > >                             ^~~~~~~~~~
> > >
> > > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> > > Signed-off-by: Jason Yan <yanaijie@xxxxxxxxxx>
> >
> > I'm sceptic about this. I think PWM37 exists and just need to be
> > properly defined.
> >
> > Mani will know the right solution to this.
>
> Sorry for missing this thread before. The original patch didn't land in my
> inbox.
>
> Anyway the issue is, pwm37 is not added to BM1880_PINCTRL_GRP. So the proper
> fix would be to add it.
>
> Jason, will you be able to send a patch for adding it? Otherwise I'll do that.

OK, I will send v2 soon.

Thanks,
Jason

> Thanks,
> Mani
>
> > Yours,
> > Linus Walleij