Re: [PATCH v2 1/3] MIPS: Massage address spaces headers

From: Jiaxun Yang
Date: Tue Apr 28 2020 - 07:47:30 EST




ä 2020å4æ28æ GMT+08:00 äå7:33:26, Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx> åå:
>On Tue, Apr 28, 2020 at 10:14:12AM +0800, Jiaxun Yang wrote:
>> That would allow us modify kernel vm address spaces without
>> step into the hell of includes.
>>
>> Also use some marcos for address spaces to make spaces.h more
>> clear.
>>
>> Signed-off-by: Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx>
>
>I don't like this patch as I can't see a good reason for shuffling
>stuff arround. Can you drop this from this series ?

The problem is without this patch we'll have to include pgtable-32.h and
pgtable-64.h into asm/io.h, and that will become totally hell.

Thanks.

>
>Thomas.
>

--
Jiaxun Yang