Re: [PATCH 2/7] staging: rtl8723bs: os_dep: remove set but not used 'size'

[Jason Yan]

å 2020/4/28 20:28, Greg KH åé:
> On Mon, Apr 27, 2020 at 11:23:37AM +0800, Jason Yan wrote:
> > And also remove the NULL check before kfree() because kfree() can handle
> > NULL pointers correctly.
> >
> > Fix the following gcc warning:
> >
> > drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:157:6: warning:
> > variable âsizeâ set but not used [-Wunused-but-set-variable]
> >    u32 size = 0;
> >        ^~~~
> >
> > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> > Signed-off-by: Jason Yan <yanaijie@xxxxxxxxxx>
> > ---
> >   drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 11 -----------
> >   1 file changed, 11 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> > index 1ba85a43f05a..b037868fbf22 100644
> > --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> > +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
> > @@ -154,17 +154,6 @@ static struct ieee80211_supported_band *rtw_spt_band_alloc(
> >   
> >   static void rtw_spt_band_free(struct ieee80211_supported_band *spt_band)
> >   {
> > -	u32 size = 0;
> > -
> > -	if (!spt_band)
> > -		return;
> > -
> > -	if (spt_band->band == NL80211_BAND_2GHZ)
> > -	{
> > -		size = sizeof(struct ieee80211_supported_band)
> > -			+ sizeof(struct ieee80211_channel)*RTW_2G_CHANNELS_NUM
> > -			+ sizeof(struct ieee80211_rate)*RTW_G_RATES_NUM;
> > -	}
> >   	kfree(spt_band);
> >   }
>
> This function can now be removed and replaced with the call to kfree(),
> right?  Can you send a follow-on patch to do that?

Sure.

> thanks,
>
> greg k-h
>
> .