Re: [PATCH 1/5] dt-bindings: bus: Add firewall bindings

[Benjamin GAIGNARD]

On 4/28/20 1:24 PM, Linus Walleij wrote:
> Hi Benjamin,
>
> On Mon, Apr 20, 2020 at 3:48 PM Benjamin Gaignard
> <benjamin.gaignard@xxxxxx> wrote:
>> Add schemas for firewall consumer and provider.
>>
>> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@xxxxxx>
>> +$id: http://devicetree.org/schemas/bus/stm32/firewall-consumer.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Common Bus Firewall consumer binding
>> +
>> +maintainers:
>> +  - Benjamin Gaignard <benjamin.gaignard@xxxxxx>
> This really needs a description: to tell what is going on and what
> these firewalls
> are for and how they are supposed to work.
Hi Linus,

Does the following description sound good for you:
Firewall properties provide the possible firewall bus controller 
configurations for a device.
Bus firewall controllers are typically used to control if a hardware 
block can perform read or write operations on bus.
The contents of the firewall bus configuration properties are defined by 
the binding for the individual firewall controller device.
The first configuration 'firewall-0' or the one named 'default' is 
applied before probing the device itself.

Regards,
Benjamin
>
> I suppose just a bit of cut'n'paste from the cover letter :D
>
> Otherwise it looks good to me.
>
> Yours,
> Linus Walleij